fix: seek bar follow-ups from the PR #59 review#60
Merged
Conversation
- Exclude the configured static delay from the display anchor: ServerToClientTime targets audio scheduling, so the delay is added back to keep the bar at measurement time; this also stops a negative delay from permanently tripping the plausibility guard into receipt anchoring. - Track identity as a (title, artist, album) tuple, eliminating the delimiter collisions of the joined-string form; log degenerate (untagged) identities where identity-based resets cannot help. - Pin boundary behavior with tests: exact 5 s anchor age, negative playback speed, and negative progress/duration clamps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes out the remaining suggestion-level findings from the PR #59 review.
IClockSynchronizer.ServerToClientTimesubtracts the configured static delay (audio-scheduling semantics). The seek bar anchor now adds it back so the displayed position reflects measurement time — a positive delay no longer runs the bar ahead, and a negative delay no longer pushes every conversion into the future, which permanently tripped the plausibility guard so the server-timestamp anchoring path silently never engaged.(title, artist, album)tuple instead of a|-joined string, eliminating delimiter collisions; a Debug log flags degenerate (fully untagged) identities where identity-based resets cannot distinguish consecutive tracks.playback_speedclamped to 0 (bar never runs backwards), negative progress/duration clamped to 0.group/updateaccurately and gains the missingserver/staterow;ServerToLocalTime→ServerToClientTime;SendSpinHostService/SendSpinClient→ actual class namesSendspinHostService/SendspinClientService.Testing