Feat/grounded timing#56
Merged
Merged
Conversation
With the after-Init StreamLatency fix in this branch, the app now reports its real device latency and 9.0.6 subtracts it from the playback schedule - so each DAC lands in sync on the server's clock with no manual StaticDelay offset.
… 9.1.0) The WDL resampler underran by ~1 frame on every speed-up callback: ResamplePrepare returns an integer input count and drops the fractional input the sinc filter needs for the last output frame, so it emitted outputFrames-1 and the shortfall was concealed with a repeated frame -- audible as a continuous tick train, and the repeat cancelled the speed-up so the correction never landed and the rate kept climbing. Drain instead: feed the small remaining input and call ResampleOut again until the full block is produced from real content. The extra read happens only on short callbacks, so average input matches the commanded rate -- no over-read, no drift. Retarget Sendspin.SDK to 9.1.0, which subtracts the ReadRaw prefill baseline (removing the constant ~100ms offset that had pinned the external corrector at its max slow rate) and adds ReportExternalPlaybackRate so Stats for Nerds shows the real correction rate; report the resampler's applied rate to the buffer for that stat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chased down several timing related issues and fixed the apps ability to use the resampler properly.
QOL == sync without side effects.