Bind service based on Activity/Fragment lifecycle#133
Merged
Conversation
Closed
chenxiaolong
force-pushed
the
exit-lifecycle
branch
2 times, most recently
from
4cf490f to
675ee83
Compare
The service connection was previously associated with the ViewModel lifecycle, which breaks the exit button when the Activity or Fragment is stopped but not destroyed. In this state, the ViewModel would never be cleared, so it would remain bound to the service, preventing the service from exiting. This commit moves the service connection logic out of the view models and into a dedicated DefaultLifecycleObserver that only maintains the connection while the lifecycle owner is in the started phase. Fixes: #130 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
force-pushed
the
exit-lifecycle
branch
from
675ee83 to
6e9bc74
Compare
chenxiaolong
added a commit
that referenced
this pull request
May 16, 2026
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service connection was previously associated with the
ViewModellifecycle, which breaks the exit button when theActivityorFragmentis stopped but not destroyed. In this state, theViewModelwould never be cleared, so it would remain bound to the service, preventing the service from exiting.This commit moves the service connection logic out of the view models and into a dedicated
DefaultLifecycleObserverthat only maintains the connection while the lifecycle owner is in the started phase.Fixes: #130