Honor exclusive ranges in EncryptedDiskService#download_chunk - #15
Open
khalilgharbaoui wants to merge 1 commit into
Open
khalilgharbaoui wants to merge 1 commit into
khalilgharbaoui wants to merge 1 commit into
Conversation
The range was passed to the scheme unchanged, and the schemes count an inclusive range, so an exclusive one returned one byte too many. ActiveStorage passes 0...4.kilobytes when it identifies a blob, and both the stock S3Service and GCSService honour exclude_end?.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
download_chunkpasses the range to the scheme unchanged, and the schemes count an inclusive range (range.end - range.begin + 1), so an exclusive range returns one byte too many.That is not hypothetical: ActiveStorage reads
0...4.kilobyteswhen it identifies a blob, so today that call returns 4097 bytes. The stockS3ServiceandGCSServiceboth honourexclude_end?, so the encrypted disk service is the odd one out.One line, plus a regression test asserting the exclusive read matches the same slice of the plaintext. 73 runs, 0 failures.