Skip to content

Issue #416: test should be updated to reuse inlined to input violation messages#418

Open
Brijeshthummar02 wants to merge 1 commit into
checkstyle:masterfrom
Brijeshthummar02:inlinetest
Open

Issue #416: test should be updated to reuse inlined to input violation messages#418
Brijeshthummar02 wants to merge 1 commit into
checkstyle:masterfrom
Brijeshthummar02:inlinetest

Conversation

@Brijeshthummar02
Copy link
Copy Markdown
Contributor

Issue #416

I updated AbstractPatchFilterEvaluationTest to support inline violation messages from input files, while keeping backward compatibility with existing expected.txt files.

Before proceeding further, should this issue also include migration of existing test input bundles to inline violation comments and removal of corresponding expected.txt files, or is the framework-level support sufficient for this PR?

@romani
Copy link
Copy Markdown
Member

romani commented May 17, 2026

Before proceeding further, should this issue also include migration of existing test input bundles to inline violation comments and removal of corresponding expected.txt files,

this is a goal.

@romani
Copy link
Copy Markdown
Member

romani commented May 17, 2026

we can upgrade tests step by step to avoid huge PRs

@Brijeshthummar02
Copy link
Copy Markdown
Contributor Author

Before proceeding further, should this issue also include migration of existing test input bundles to inline violation comments and removal of corresponding expected.txt files,

this is a goal.

So i made a small focused migration by moving violations from expected.txt into inline comments for two representative bundles:

  • FileTabCharacter/SingleNewLine
  • MoveCodeToAnotherFileWithMinorChanges

Removed the corresponding expected.txt files and updated the shared test helper to handle column-prefixed messages.

Should further migration of remaining test bundles be continued in this PR or handled in separate follow-up PRs?

@Brijeshthummar02
Copy link
Copy Markdown
Contributor Author

we can upgrade tests step by step to avoid huge PRs

For the testing part, i did some migration in this PR so you can check it. Once this get's merged i will migrate all remaining test bundles one by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants