Conversation
jchook
marked this pull request as ready for review
September 7, 2026 07:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VHS enables sixel in ttyd but omits the image canvas when capturing frames.
Set Sixel truenow captures that layer and includes it in videos, screenshots, and exported frames. It defaults to false, following the performance concern in #43 (comment).The addon creates and removes its canvas as images enter and leave the screen. Capture queries and reads the current canvas in one browser evaluation, writes transparent frames when it is absent, and scales image pixels to the text canvas dimensions when needed. FFmpeg overlays text, image, then cursor. Loop offsets move all layers and update screenshot references.
The first commit fixes a prerequisite regression:
Evaluatecanceled its recording context before passing it to FFmpeg, producing no output files. Recording now uses a child context while rendering retains the parent. The new end-to-end output test failed before that fix and passes with it.Related to #43; completes the image-capture step described in #137.
Standalone example
Run
vhs examples/sixel.tapefrom the repository root. The tape emits sixel using shellprintf; it needs no image encoder or ttyd fork.