Use bigint for PostgreSQL ASN fields#2713
Open
0xTaoZ wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2712 by generating PostgreSQL
bigintcolumns for harmonization fields of typeASN.IntelMQ's ASN harmonization type accepts valid 4-byte ASNs up to
4294967295, including private ASNs such as4200393735. The PostgreSQL schema generator previously mappedASNtogether with genericIntegertointeger, which cannot store values above2147483647and can fail withpsycopg2.errors.NumericValueOutOfRangewhen importing valid data.Changes
ASNfields to PostgreSQLbigintinintelmq_psql_initdb.Integerfields mapped to PostgreSQLinteger.source.asnanddestination.asn.Validation
python -m pytest intelmq/tests/bin/test_psql_initdb.py intelmq/tests/lib/test_harmonization.pyResult:
100 passed.Risk
This only affects newly generated PostgreSQL schemas.
bigintis a wider integer type, so it supports the current ASN range without narrowing existing accepted values.