smtp_batch: proper exit code when non-interactive

[Lukas-Heindl]

This is only related to #2586 as that issue covers more than this PR. For the rest see the commit message.

[Lukas-Heindl]

From my side this would be already finished (if the tests pass, but I expect them to do so with that little changes). Is there anything left to do for me?

[sebix]

The tests are broken, #2602 would fix that.

Do you mean smtp_batch: proper exit code when non-interactive?

[Lukas-Heindl]

No I think it's right this way. When the bot is interactive, I assume the exit code is not that important since a human is reading the output anyhow (also how to set the exit code if the first command (e.g. sending the first debug mail failed) but the second command succeded?).

So this change is supposed to handle the case when the bot is run via cli, but e.g. as cron job (so not interactively but with the --send flag). In this case no human reads the output usually and the exit code can help in triggering an alert something has gone wrong (triggering a human to look into the issue).

tests

So do I understand this correctly, are all PRs suspended at the moment, until that test-case is fixed?

[Lukas-Heindl]

Now with the tests fixed, can you trigger the workflows on this?

[sebix]

No I think it's right this way. When the bot is interactive, I assume the exit code is not that important since a human is reading the output anyhow (also how to set the exit code if the first command (e.g. sending the first debug mail failed) but the second command succeded?).

So this change is supposed to handle the case when the bot is run via cli, but e.g. as cron job (so not interactively but with the --send flag). In this case no human reads the output usually and the exit code can help in triggering an alert something has gone wrong (triggering a human to look into the issue).

Thanks for the explanation. I confused (non-)interactive with the bot run mode (continuous/scheduled). Your logic makes sense of course :)

(also how to set the exit code if the first command (e.g. sending the first debug mail failed) but the second command succeded?).

My 2 cents on this - but I'm not a user of this bot: If any error occurred, the exit code would be non-zero (or the maximum of all potential exit codes). But that's neither important nor urgent to do.