Skip to content

add design doc for ClientProfileReplication - #489

Merged
Madhu-1 merged 1 commit into
ceph:mainfrom
rewantsoni:replacement-destination-info-design
Jun 29, 2026
Merged

add design doc for ClientProfileReplication#489
Madhu-1 merged 1 commit into
ceph:mainfrom
rewantsoni:replacement-destination-info-design

Conversation

@rewantsoni

@rewantsoni rewantsoni commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Describe what this PR does

Add the design doc related to the new ClientProfileReplication CR

Is there anything that requires special attention

Provide any external context for the change, if any.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@rewantsoni
rewantsoni force-pushed the replacement-destination-info-design branch 2 times, most recently from 2645296 to 71057a7 Compare June 3, 2026 11:11
@rewantsoni
rewantsoni force-pushed the replacement-destination-info-design branch from 71057a7 to 52ac2ca Compare June 16, 2026 11:33

@iPraveenParihar iPraveenParihar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rewantsoni Need clarification.

Comment thread docs/design/operator.md Outdated
Comment thread docs/design/operator.md Outdated
Comment thread docs/design/operator.md Outdated
@rewantsoni
rewantsoni force-pushed the replacement-destination-info-design branch from 52ac2ca to a00253b Compare June 23, 2026 04:11

@Madhu-1 Madhu-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments when i look at this as standalone design doc.

  • The design doc should also point to the consumption model on how DR will update the volume Handles
  • Migration path for existing clusters, Need to cover what happens on the upgraded cluster where we have PVC with old volumeHandle
  • CO-existance behaviour of both Replicationdesitination and client profile mapping
  • What happens if 2 ReplicationDestinationConfig contains same localClientProfile?
  • What happens if ReplicationDestinationConfig contains same localClientProfile but there is no clientProfile with the name yet?
  • Missing details of which configmap key will be updataed for this new CRD
  • Controller high level design, How 2 controllers will coordinates as they need to update the same key contents in the same configmap
  • How we are ensureing the tight couping between the new CR and the clientProfile. if the clientProfile CR is deleted the entries in configmap will also gets
    deleted even though we have ReplicationDestinationConfig
  • Add a statement that poolNames are same across the clusters
  • Add CRD defination as part of design
  • Need to call out that design considered pool names as constamtt if ever pools are renamed. the corresponding details need to be updated on the CR as well.

Comment thread docs/design/operator.md Outdated
Comment thread docs/design/operator.md Outdated
Comment thread docs/design/operator.md Outdated
Comment thread docs/design/operator.md Outdated
Comment thread docs/design/operator.md Outdated
@rewantsoni
rewantsoni force-pushed the replacement-destination-info-design branch 2 times, most recently from 2f8ab94 to 6c56ed2 Compare June 24, 2026 08:31
@rewantsoni
rewantsoni requested a review from Madhu-1 June 24, 2026 08:33
@rewantsoni
rewantsoni force-pushed the replacement-destination-info-design branch from 6c56ed2 to 2888110 Compare June 24, 2026 09:18
@rewantsoni rewantsoni changed the title add design doc for ReplicationDestinationConfig add design doc for ClientProfileReplication Jun 25, 2026
Comment thread docs/design/replication.md Outdated
add the design doc related to the new ReplicationDestinationConfig
CR

Signed-off-by: Rewant Soni <resoni@redhat.com>
@rewantsoni
rewantsoni force-pushed the replacement-destination-info-design branch from 2888110 to 6c55a1f Compare June 25, 2026 06:18
@Madhu-1
Madhu-1 merged commit cd5a9a2 into ceph:main Jun 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants