add design doc for ClientProfileReplication - #489
Merged
Madhu-1 merged 1 commit intoJun 29, 2026
Conversation
rewantsoni
force-pushed
the
replacement-destination-info-design
branch
2 times, most recently
from
June 3, 2026 11:11
2645296 to
71057a7
Compare
rewantsoni
force-pushed
the
replacement-destination-info-design
branch
from
June 16, 2026 11:33
71057a7 to
52ac2ca
Compare
iPraveenParihar
left a comment
Contributor
There was a problem hiding this comment.
@rewantsoni Need clarification.
rewantsoni
force-pushed
the
replacement-destination-info-design
branch
from
June 23, 2026 04:11
52ac2ca to
a00253b
Compare
Madhu-1
reviewed
Jun 24, 2026
Madhu-1
left a comment
Collaborator
There was a problem hiding this comment.
Couple of comments when i look at this as standalone design doc.
- The design doc should also point to the consumption model on how DR will update the volume Handles
- Migration path for existing clusters, Need to cover what happens on the upgraded cluster where we have PVC with old volumeHandle
- CO-existance behaviour of both Replicationdesitination and client profile mapping
- What happens if 2 ReplicationDestinationConfig contains same localClientProfile?
- What happens if ReplicationDestinationConfig contains same localClientProfile but there is no clientProfile with the name yet?
- Missing details of which configmap key will be updataed for this new CRD
- Controller high level design, How 2 controllers will coordinates as they need to update the same key contents in the same configmap
- How we are ensureing the tight couping between the new CR and the clientProfile. if the clientProfile CR is deleted the entries in configmap will also gets
deleted even though we have ReplicationDestinationConfig - Add a statement that poolNames are same across the clusters
- Add CRD defination as part of design
- Need to call out that design considered pool names as constamtt if ever pools are renamed. the corresponding details need to be updated on the CR as well.
rewantsoni
force-pushed
the
replacement-destination-info-design
branch
2 times, most recently
from
June 24, 2026 08:31
2f8ab94 to
6c56ed2
Compare
rewantsoni
force-pushed
the
replacement-destination-info-design
branch
from
June 24, 2026 09:18
6c56ed2 to
2888110
Compare
Madhu-1
reviewed
Jun 25, 2026
add the design doc related to the new ReplicationDestinationConfig CR Signed-off-by: Rewant Soni <resoni@redhat.com>
rewantsoni
force-pushed
the
replacement-destination-info-design
branch
from
June 25, 2026 06:18
2888110 to
6c55a1f
Compare
6 tasks
Madhu-1
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
Add the design doc related to the new ClientProfileReplication CR
Is there anything that requires special attention
Provide any external context for the change, if any.
Checklist: