v055y-version code bump#2866
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the app/module version code for the v055y release and updates the pinned firestack commit, then aligns multiple VPN/proxy/DNS status APIs and UI helpers to use Int-based status IDs (instead of Long) to match the updated backend.
Changes:
- Bump
VERSION_CODE/android:versionCodefrom 62 → 63 and updatefirestackCommit. - Change proxy / DNS / hop status return types across service, controller, adapter, and UI layers from
LongtoInt. - Update
Transaction.Statusto useIntIDs and iterate enums viaenumEntries.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle.properties | Bumps module version code and updates firestackCommit. |
| app/src/main/AndroidManifest.xml | Bumps manifest versionCode to 63. |
| app/src/main/java/com/celzero/bravedns/service/VpnController.kt | Updates public controller APIs to return Int status IDs. |
| app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt | Propagates Int status ID APIs; adjusts proxy-added flow to refresh proxies after add. |
| app/src/main/java/com/celzero/bravedns/net/go/GoVpnAdapter.kt | Updates adapter status APIs to return Int IDs. |
| app/src/main/java/com/celzero/bravedns/net/doh/Transaction.kt | Switches Transaction.Status IDs to Int and uses enumEntries. |
| app/src/main/java/com/celzero/bravedns/rpnproxy/RpnProxyManager.kt | Updates RPN status fields to Int / Int?. |
| app/src/full/java/com/celzero/bravedns/util/UIUtils.kt | Updates UI status helpers/enums to use Int status IDs. |
| app/src/full/java/com/celzero/bravedns/ui/fragment/HomeScreenFragment.kt | Updates DNS error helper to accept Int? status IDs. |
| app/src/full/java/com/celzero/bravedns/ui/adapter/VpnServerAdapter.kt | Updates stats application pipeline to use Pair<Int?, String>. |
| app/src/full/java/com/celzero/bravedns/ui/activity/WgConfigDetailActivity.kt | Updates DNS error helper to accept Int? status IDs. |
| app/src/full/java/com/celzero/bravedns/ui/activity/RpnConfigDetailActivity.kt | Updates stats application signature to use Pair<Int?, String>. |
| app/src/full/java/com/celzero/bravedns/ui/activity/ProxySettingsActivity.kt | Updates DNS/proxy status helpers to use Int-typed status IDs. |
| app/src/full/java/com/celzero/bravedns/service/WireguardManager.kt | Updates WG stats status field to Int?. |
| app/src/full/java/com/celzero/bravedns/adapter/WgConfigAdapter.kt | Updates status UI update pipeline to Int-typed IDs. |
| app/src/full/java/com/celzero/bravedns/adapter/OneWgConfigAdapter.kt | Updates status UI update pipeline to Int-typed IDs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+253
to
255
| suspend fun getProxyStatusById(id: String): Pair<Int?, String> { | ||
| return braveVpnService?.getProxyStatusById(id) ?: Pair(null, "vpn service not available") | ||
| } |
Comment on lines
+374
to
376
| suspend fun getDnsStatus(id: String): Int? { | ||
| return braveVpnService?.getDnsStatus(id) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.