feat: Adding HTTP proxy support for reliability#710
Conversation
Kimchi Code Review
Summary📊 Review Score: 92/100 (overall code quality — 0 lowest, 100 highest) 🧪 Tests: no — No automated tests were added for the Helm template changes. While Helm template testing is not always standard practice, complex conditional logic like the No significant issues found. LGTM! 🎉 What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
There was a problem hiding this comment.
📊 Review Score: 92/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 2/5 (1 = trivial, 5 = very complex)
🧪 Tests: no — No automated tests were added for the Helm template changes. While Helm template testing is not always standard practice, complex conditional logic like the kvisor.proxyEnvVars helper could benefit from helm template command validation or unit tests using helm-unittest to verify correct indentation and conditional rendering across nil/empty/non-empty value scenarios.
No significant issues found. LGTM! 🎉
Kimchi Summary
What changed
Add support for injecting
HTTP_PROXY,HTTPS_PROXY, andNO_PROXYenvironment variables into kvisor components that initiate external connections. Each variable is independently optional and emitted only when its correspondingglobal.proxyvalue is non-empty.Why
Enable kvisor deployment in environments where outbound traffic to the CAST AI mothership must route through corporate HTTP CONNECT proxies.
Key changes
values.yaml: Introduceglobal.proxyconfiguration block withhttpProxy,httpsProxy, andnoProxyfields_helpers.tpl: Addkvisor.proxyEnvVarshelper template to conditionally render proxy environment variablestemplates/agent.yaml: Includekvisor.proxyEnvVarsin agent container environment specificationtemplates/controller.yaml: Includekvisor.proxyEnvVarsin controller container environment specificationChart.yaml: Bumpreliability-metrics-ch-exporterdependency to0.3.19to support proxy configuration propagation via global valuesdocs/reliability-stack-installation.md: Add proxy configuration section documenting supported components and exclusionsImpact
global.proxyvalues automatically propagate to thereliabilityMetricssubchart via Helm's global values mechanism.