Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

feat: Adding HTTP proxy support for reliability#710

Merged
ruckgy merged 2 commits into
mainfrom
http-proxy-support
May 6, 2026
Merged

feat: Adding HTTP proxy support for reliability#710
ruckgy merged 2 commits into
mainfrom
http-proxy-support

Conversation

@ruckgy

@ruckgy ruckgy commented May 5, 2026

Copy link
Copy Markdown
Contributor

Kimchi Summary

What changed

Add support for injecting HTTP_PROXY, HTTPS_PROXY, and NO_PROXY environment variables into kvisor components that initiate external connections. Each variable is independently optional and emitted only when its corresponding global.proxy value is non-empty.

Why

Enable kvisor deployment in environments where outbound traffic to the CAST AI mothership must route through corporate HTTP CONNECT proxies.

Key changes

  • values.yaml: Introduce global.proxy configuration block with httpProxy, httpsProxy, and noProxy fields
  • _helpers.tpl: Add kvisor.proxyEnvVars helper template to conditionally render proxy environment variables
  • templates/agent.yaml: Include kvisor.proxyEnvVars in agent container environment specification
  • templates/controller.yaml: Include kvisor.proxyEnvVars in controller container environment specification
  • Chart.yaml: Bump reliability-metrics-ch-exporter dependency to 0.3.19 to support proxy configuration propagation via global values
  • docs/reliability-stack-installation.md: Add proxy configuration section documenting supported components and exclusions

Impact

  • Scope limitation: Proxy variables are intentionally excluded from OBI and OpenTelemetry collector sidecars. OBI communicates only over localhost, and collectors write to ClickHouse via native TCP (unaffected by HTTP proxies).
  • Subchart propagation: global.proxy values automatically propagate to the reliabilityMetrics subchart via Helm's global values mechanism.
  • Additive only: No breaking changes; existing deployments without proxy configuration continue to function unchanged.

@kimchi-review

kimchi-review Bot commented May 5, 2026

Copy link
Copy Markdown

Kimchi Code Review

Property Value
Commit db77db2
Author @ruckgy
Files changed 0
Review status Completed
Comments 0
Duration 20s

Summary

📊 Review Score: 92/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 2/5 (1 = trivial, 5 = very complex)

🧪 Tests: no — No automated tests were added for the Helm template changes. While Helm template testing is not always standard practice, complex conditional logic like the kvisor.proxyEnvVars helper could benefit from helm template command validation or unit tests using helm-unittest to verify correct indentation and conditional rendering across nil/empty/non-empty value scenarios.

No significant issues found. LGTM! 🎉

What to expect

Kimchi will analyze the changes in this pull request and post:

  • A summary of the overall changes
  • Inline comments on specific lines with findings categorized by issue type

The review typically completes within a few minutes. This comment will be updated once the review is ready.

Interact with Kimchi
  • @kimchi review — re-trigger a full review on the latest commit
  • @kimchi summary — regenerate the PR summary
  • @kimchi ignore — skip this PR (no review will be posted)
  • Reply to any inline comment to ask follow-up questions or request clarification
Configuration

Reviews are configured by your organization admin.
Review instructions, excluded directories, and severity thresholds can be adjusted per repository in the Kimchi dashboard.


Powered by Kimchi — AI-powered code review by CAST AI

@kimchi-review kimchi-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Review Score: 92/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 2/5 (1 = trivial, 5 = very complex)

🧪 Tests: no — No automated tests were added for the Helm template changes. While Helm template testing is not always standard practice, complex conditional logic like the kvisor.proxyEnvVars helper could benefit from helm template command validation or unit tests using helm-unittest to verify correct indentation and conditional rendering across nil/empty/non-empty value scenarios.

No significant issues found. LGTM! 🎉

@ruckgy ruckgy merged commit 45aa448 into main May 6, 2026
5 of 6 checks passed
@ruckgy ruckgy deleted the http-proxy-support branch May 6, 2026 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants