Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

feat: Addin open-ports flag for OBI and dataflow verification#706

Merged
ruckgy merged 6 commits into
mainfrom
open-port-support
May 5, 2026
Merged

feat: Addin open-ports flag for OBI and dataflow verification#706
ruckgy merged 6 commits into
mainfrom
open-port-support

Conversation

@ruckgy

@ruckgy ruckgy commented May 1, 2026

Copy link
Copy Markdown
Contributor

Kimchi Summary

What changed

Added --open-ports flag to the reliability stack installation script and replaced the basic DaemonSet check with comprehensive end-to-end verification that confirms the entire metrics pipeline is operational.

Why

Operators need to control which ports OBI instruments for process discovery without editing Helm values files. Additionally, the previous verification only checked pod status, leaving users uncertain whether data was actually flowing through Bronze → Silver → Exporter stages. Automated verification reduces time-to-confidence and surfaces configuration issues immediately.

Key changes

  • charts/kvisor/scripts/enable-reliability-stack.sh:

    • Added --open-ports CLI flag with validation (comma-separated ports, range 1-65535) and proper comma-escaping for Helm --set syntax
    • Replaced simple DaemonSet check with multi-stage verification: Agent DaemonSet rollout, OBI container state, OTel Collector state, Controller Deployment rollout, ClickHouse readiness, migration job completion, and end-to-end data pipeline validation (Bronze metrics → Silver aggregation → Exporter pushing to CAST AI)
    • Added VERIFY_FAILURES counter and conditional summary output (success vs. warning states with targeted troubleshooting steps)
  • docs/reliability-stack-installation.md:

    • Documented --open-ports usage in examples and added section describing the automated Phase 3 verification workflow

Impact

  • Installation now takes 2–4 minutes longer as the script waits for ClickHouse reconciliation, migrations, and confirms data flow through the pipeline before completing
  • Port configuration can now be specified inline via --open-ports 8080,8443,6379 instead of requiring a values file override

@kimchi-review

kimchi-review Bot commented May 1, 2026

Copy link
Copy Markdown

Kimchi Code Review

Property Value
Commit bfe3234
Author @ruckgy
Files changed 0
Review status Completed
Comments 2 (2 info)
Duration 41s

Summary

📊 Review Score: 88/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 2/5 (1 = trivial, 5 = very complex)

🧪 Tests: no — No automated tests are included for the shell script changes. This is typical for operational bash scripts, though the script includes extensive defensive validation and error handling logic that serves as runtime verification.

📝 Found 2 issue(s). See inline comments for details.

What to expect

Kimchi will analyze the changes in this pull request and post:

  • A summary of the overall changes
  • Inline comments on specific lines with findings categorized by issue type

The review typically completes within a few minutes. This comment will be updated once the review is ready.

Interact with Kimchi
  • @kimchi review — re-trigger a full review on the latest commit
  • @kimchi summary — regenerate the PR summary
  • @kimchi ignore — skip this PR (no review will be posted)
  • Reply to any inline comment to ask follow-up questions or request clarification
Configuration

Reviews are configured by your organization admin.
Review instructions, excluded directories, and severity thresholds can be adjusted per repository in the Kimchi dashboard.


Powered by Kimchi — AI-powered code review by CAST AI

@kimchi-review kimchi-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Review Score: 88/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 2/5 (1 = trivial, 5 = very complex)

🧪 Tests: no — No automated tests are included for the shell script changes. This is typical for operational bash scripts, though the script includes extensive defensive validation and error handling logic that serves as runtime verification.

📝 Found 2 issue(s). See inline comments for details.

Comment thread charts/kvisor/scripts/enable-reliability-stack.sh
Comment thread charts/kvisor/scripts/enable-reliability-stack.sh
Comment thread charts/kvisor/scripts/enable-reliability-stack.sh
Comment thread charts/kvisor/scripts/enable-reliability-stack.sh
Comment thread charts/kvisor/scripts/enable-reliability-stack.sh Outdated
@ruckgy ruckgy merged commit ba8ba72 into main May 5, 2026
3 checks passed
@ruckgy ruckgy deleted the open-port-support branch May 5, 2026 04:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants