feat: Addin open-ports flag for OBI and dataflow verification#706
Conversation
Kimchi Code Review
Summary📊 Review Score: 88/100 (overall code quality — 0 lowest, 100 highest) 🧪 Tests: no — No automated tests are included for the shell script changes. This is typical for operational bash scripts, though the script includes extensive defensive validation and error handling logic that serves as runtime verification. 📝 Found 2 issue(s). See inline comments for details. What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
There was a problem hiding this comment.
📊 Review Score: 88/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 2/5 (1 = trivial, 5 = very complex)
🧪 Tests: no — No automated tests are included for the shell script changes. This is typical for operational bash scripts, though the script includes extensive defensive validation and error handling logic that serves as runtime verification.
📝 Found 2 issue(s). See inline comments for details.
Kimchi Summary
What changed
Added
--open-portsflag to the reliability stack installation script and replaced the basic DaemonSet check with comprehensive end-to-end verification that confirms the entire metrics pipeline is operational.Why
Operators need to control which ports OBI instruments for process discovery without editing Helm values files. Additionally, the previous verification only checked pod status, leaving users uncertain whether data was actually flowing through Bronze → Silver → Exporter stages. Automated verification reduces time-to-confidence and surfaces configuration issues immediately.
Key changes
charts/kvisor/scripts/enable-reliability-stack.sh:--open-portsCLI flag with validation (comma-separated ports, range 1-65535) and proper comma-escaping for Helm--setsyntaxVERIFY_FAILUREScounter and conditional summary output (success vs. warning states with targeted troubleshooting steps)docs/reliability-stack-installation.md:--open-portsusage in examples and added section describing the automated Phase 3 verification workflowImpact
--open-ports 8080,8443,6379instead of requiring a values file override