Keep library sidebars mounted across document switches - #55
Merged
Merged
Conversation
written with gpt-6 in Codex
written with gpt-6 in Codex
…r-persistence Assisted-by: gpt-6 in Codex
written with gpt-6 in Codex
written with gpt-6 in Codex
written with gpt-6 in Codex
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
written with gpt-6 in Codex
carlassmann
marked this pull request as ready for review
September 27, 2026 17:09
written with gpt-6 in Codex
written with gpt-6 in Codex
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document switches rebuilt the library sidebar and lost search state. Keep personal and space sidebars mounted while document-keyed editors reset their state. The personal account subscription moves into the persistent parent; space changes still reset the space sidebar.
The diff contains two screen changes, lifecycle documentation, and a user-facing changelog entry. It also rewrites 62 existing changelog entries around what readers can do or notice, preserving their IDs, dates and release links. The contributor guidance now requires that style. Benchmark data and one-off tooling are excluded.
Validation: desktop personal/space save routing, undo isolation and retained search; mobile document switching; collaboration convergence and document-only space access.
bun run cipassed 950 unit tests, all 10 E2E cases, static checks, and the production build. Exact-headsignoff: successis recorded for85c6936890c7581cd279879d9d6d06fd00c53525after the changelog copy edits.Remaining gaps: remote permission revocation, remote asset sync, tab closure immediately after navigating away from a pending edit, and same-document moves between spaces were not revalidated. Their mechanisms are unchanged. One Opus/Sol review round found no confirmed introduced product regression.
Desktop and mobile screenshots (unchanged app code)
written with gpt-6 in Codex