Classify a prefix-form module reference as absolute - #5927
Open
backspace wants to merge 1 commit into
Open
Conversation
`isRelativePath` asked only whether a value parses as a URL. `URL.canParse` says no for a registered prefix, so the canonical spelling of every base-realm module read as a relative path and `resolveAdoptsFrom` sent it down relative resolution. Nothing breaks today: that path passes a prefix form through unchanged, and `resolveModuleHref` admits one before resolving. The classification was wrong while the outcome was right, resting on a downstream tolerance rather than on knowing what the value was. The `@` discriminator is the one the codebase already uses for this question — `resolveRRIReference`, which receives whatever this classifies, opens with the same test, and `isLocalId` records why it needs no VirtualNetwork: the two remote forms are syntactically distinguishable. Since both routes agree, no behaviour distinguishes them and a regression would be silent, so the classifier is asserted directly and exported for that. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
backspace
marked this pull request as ready for review
August 28, 2026 18:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup from #5847 feedback, in the RRI/
@cardstack/baseproject.Claude:
isRelativePathasked only whether a value parses as a URL.URL.canParsesays no for a registered prefix, so the canonical spelling of every base-realm module read as a relative path andresolveAdoptsFromsent it down relative resolution.Nothing breaks today: that path passes a prefix form through unchanged, and
resolveModuleHrefadmits one before resolving. The classification was wrong while the outcome was right, resting on a downstream tolerance rather than on knowing what the value was.The
@discriminator is the one the codebase already uses for this question —resolveRRIReference, which receives whatever this classifies, opens with the same test, andisLocalIdrecords why it needs no VirtualNetwork: the two remote forms are syntactically distinguishable.Since both routes agree, no behaviour distinguishes them and a regression would be silent, so the classifier is asserted directly and exported for that.