Delete the base realm's stale Skill card copies - #5876
Draft
jurgenwerk wants to merge 2 commits into
Draft
Conversation
…ll reference them The skills realm (@cardstack/skills) is the source of the boxel-development, boxel-environment, catalog-listing and source-code-editing skills. The copies under packages/base/Skill were stale duplicates nothing loaded through code anymore. Rooms created before this change can still hold an enabled skill card whose URL no longer resolves. Loading such a skill now fails on its own instead of aborting the load of every other skill in the room, and the skill menu renders the dead reference as a 'Skill unavailable' pill that can still be toggled off. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
…he panel opens it Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four skill card instances under
packages/base/Skill(boxel-development,boxel-environment,catalog-listing,source-code-editing) were stale copies of skills that the skills realm (@cardstack/skills) already serves. Nothing in the host resolves skills through the base realm anymore (skillCardURL()always builds an@cardstack/skills/Skill/...reference), so this deletes them.Two references had to move with them: an acceptance test used
base/Skill/catalog-listingas a recent card to exercise "create instance from a read-only realm" and now usesbase/Theme/boxel-brand-guidefor the same purpose, and one experiments-realm environment card linked to the base copy ofboxel-environmentand now points at the skills realm like its sibling links.Old assistant rooms can still hold an enabled skill card whose URL is one of the deleted paths (or any other skill that was deleted or renamed later). Two changes make that degrade instead of break:
RoomResource.loadSkillsnow loads each enabled skill on its own. A skill that fails to download or resolve logs a warning and is skipped, so the other skills in the room still load and the room still opens. Before, one bad skill aborted the whole skills load.A new integration test opens a room whose only enabled skill points at a non-existent card and asserts the room settles and the unavailable pill with its toggle is shown.