Skip to content

forward deltas == backward deltas? #12

Description

@MaciejSkrabski

The deltas are identical in both directions

I do not know if this is intended. I do not see it justified in the paper. This means, that backward deltas do not apply to backward mask. I have noticed you have inverted masks twice for backward input processing:

  1. first you invert masks when sending an argument to parse_rec function;
  2. then you reverse masks again in parse_delta in if dir_ == 'backward'

So whatever bidirectional thing you calculate, the deltas do not align, so the temp decay is wrong, so the gammas... and so on.
Allow me to suggest creating tests using single dimensional data.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions