feat(signing-fireblocks): make coin type configurable with backward-c…#2065
Open
HelmiTrabelsi wants to merge 2 commits into
Open
feat(signing-fireblocks): make coin type configurable with backward-c…#2065HelmiTrabelsi wants to merge 2 commits into
HelmiTrabelsi wants to merge 2 commits into
Conversation
…ompatible default Signed-off-by: HelmiTrabelsi <hilmi-102@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CC_COIN_TYPEwas hardcoded to6767insideFireblocksHandler, making itimpossible to configure a different derivation path coin type without forking
the package. This change makes it configurable while keeping full backward
compatibility.
Changes
coinType?: numbertoFireblocksConfigandFireblocksHandlerconstructor. It defaults to
CC_COIN_TYPE(6767) when omittedCC_COIN_TYPE = 6767remains exported fromcore-signing-libunchangedUsage