Add FA weights to CIP-0104 spec#238
Open
bame-da wants to merge 3 commits into
Open
Conversation
bame-da
requested review from
hythloda,
isegall-da,
omaiko-intellecteu,
stas-sbi,
tkatrichenko and
waynecollier-da
meiersi-da
reviewed
Jun 30, 2026
|
|
||
| Note that the computation in Item 5 takes care of distributing the traffic cost not attributed to app envelopes in a weighted fashion among the app envelopes. | ||
| When all envelopes have an app confirmer, it becomes `per_app_traffic_weight = envelope_traffic_cost / num_app_confirmers`, as expected. | ||
| See the [Example: Views and Envelopes for DvP settlement](#example-views-and-envelopes-for-dvp-settlement) section for concrete calculation examples. |
Contributor
There was a problem hiding this comment.
What about adjusting the example with one non-default weight to create certainty?
meiersi-da
reviewed
Jun 30, 2026
|
|
||
| ### Free Protocol-Conformant Confirmation Responses | ||
|
|
||
| The Canton Protocol is changed so that the confirmation responses expected to be sent by a confirming participant node become de-facto free. |
Contributor
There was a problem hiding this comment.
Missing later below: adjust the changelog. Also have a look at the header. I believe there's some changelog as well.
Contributor
Author
There was a problem hiding this comment.
I adjusted the changelog at the bottom, I saw nothing at the top.
Co-authored-by: Simon Meier <simon@digitalasset.com> Signed-off-by: Bernhard Elsner <40762178+bame-da@users.noreply.github.com>
Signed-off-by: Bernhard Elsner <40762178+bame-da@users.noreply.github.com>
4 tasks
meiersi-da
reviewed
Jul 2, 2026
meiersi-da
left a comment
meiersi-da
left a comment
Contributor
There was a problem hiding this comment.
based on the PoC implementation in: https://github.com/canton-network/splice/pull/6208/changes#r3511208187
| When all envelopes have an app confirmer, it becomes `per_app_traffic_weight = envelope_traffic_cost / num_app_confirmers`, as expected. | ||
| See the [Example: Views and Envelopes for DvP settlement](#example-views-and-envelopes-for-dvp-settlement) section for concrete calculation examples. | ||
|
|
||
| The computations are performed using integer arithmetic for efficiency and determinism reasons. |
Contributor
There was a problem hiding this comment.
Suggested change
| The computations in steps 1-5 are performed using integer arithmetic for efficiency and determinism reasons. |
| See the [Example: Views and Envelopes for DvP settlement](#example-views-and-envelopes-for-dvp-settlement) section for concrete calculation examples. | ||
|
|
||
| The computations are performed using integer arithmetic for efficiency and determinism reasons. | ||
| For confirmation requests whose traffic size is below 100 MB, they can be performed with 64-bit signed integers without risk of overflow. |
Contributor
There was a problem hiding this comment.
Suggested change
| For confirmation requests whose traffic size is below 100 MB, they can be performed with 64-bit signed integers without risk of overflow. | |
| The computation in Step 6 is performed using Daml's `Decimal` arithmetic as `floor (intToDecimal per_app_traffic_weight * activityWeight)`. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app marker mechanism at the moment allows governance bodies to respond to observed behaviours and imbalances by amending marker guidance, observing through public explorers, and enforcement.
We propose to add a "featured app weights" to CIP-0104 that would allow similarly fine-grained adjustments to app rewards on a per-app basis.