fix(fsm): check closure error 'e' not outer 'err' in ConformStateToParamUpdate - #494
Open
Sertug17 wants to merge 1 commit into
Open
fix(fsm): check closure error 'e' not outer 'err' in ConformStateToParamUpdate#494Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
…teToParamUpdate In ConformStateToParamUpdate(), after calling SetValidatorUnstakingIfBelowMinimum, the code checked the outer 'err' variable (still nil inside the closure) instead of the closure's own named return variable 'e'. This caused errors from SetValidatorUnstakingIfBelowMinimum to be silently discarded, potentially leaving validators below minimum stake active after a governance parameter update. Fixes canopy-network#493
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #493
Problem
In
ConformStateToParamUpdate()(fsm/gov.go), the error returned bySetValidatorUnstakingIfBelowMinimumwas assigned to the closure's named return variablee, but the condition checked the outer function-scope variableerrwhich is alwaysnilinside the closure (it only gets assigned whenIterateAndExecutereturns).This caused errors to be silently discarded, potentially leaving validators below the new minimum stake active in committees after a governance parameter update.
Fix
One-line change:
err != nil→e != nil