fix: resolve data race and leaked dialing counter in DialForOutboundPeers - #492
Open
Sertug17 wants to merge 1 commit into
Open
fix: resolve data race and leaked dialing counter in DialForOutboundPeers#492Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
- Replace plain int dialing counter with sync/atomic.Int64 to eliminate data race between spawned goroutines and the main loop - Add deferred dialing.Add(-1) in initial DialPeers goroutines so the counter correctly drops back when each dial completes Fixes canopy-network#491
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the data race and permanent counter inflation reported in #491.
Changes in
p2p/p2p.gointdialingvariable withsync/atomic.Int64to eliminate the data race between the initialDialPeersgoroutines and the main loopdefer dialing.Add(-1)in the initial goroutines so the counter correctly decrements when eachDialWithBackoffcall completes.Add()and.Load()Before
After
Closes #491