chore: skip Percy on Blocked PRs even with the Percy label#5812
Open
Onibenjo wants to merge 1 commit into
Open
chore: skip Percy on Blocked PRs even with the Percy label#5812Onibenjo wants to merge 1 commit into
Onibenjo wants to merge 1 commit into
Conversation
Demo
Jenkins 
demos.haus 
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the “Percy (labeled)” GitHub Actions workflow so it will not run for pull requests that have a Blocked ⛔ label present, even if Review: Percy needed is applied. This prevents repeated Percy runs on abandoned/blocked PRs (notably Renovate PRs that continue to rebase and retrigger synchronize events).
Changes:
- Add a job-level guard to skip the workflow whenever any PR label contains the substring
Blocked. - Apply the guard consistently for both workflow trigger paths (
labeledandsynchronize) so neither labeling nor new commits will start Percy while blocked.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
immortalcodes
approved these changes
Jun 9, 2026
immortalcodes
left a comment
immortalcodes
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks, this will be helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Percy (labeled)workflow so it never runs when a PR carries theBlocked ⛔label, even ifReview: Percy neededis present.Blockedas a substring (robust to the emoji/trailing space; no other label contains it).labeledandsynchronize), so neither adding the Percy label nor pushing/rebasing a blocked PR will start a build.Why: a Renovate PR was labelled
Review: Percy needed, then hit a problem and was markedBlocked ⛔and abandoned. Renovate kept rebasing it ~2–4×/week, and eachsynchronizefaithfully ran a full ~700-screenshot Percy build for months. The label was doing its job; it just outlived its purpose on a PR that could never merge.Effect: healthy labelled PRs (including legitimate Renovate version-bump visual checks) are unaffected and still re-check on each rebase.
Blocked ⛔now acts as a pause/resume switch.CI-only change — no SCSS/macro changes, so no version bump or release-notes entry needed.
Fixes — ticket WD-37050
QA
Review: Percy neededandBlocked ⛔: push a commit → confirm thePercy (labeled)workflow does not trigger.Review: Percy needed(noBlocked ⛔): push a commit → confirm Percy still runs as before.Blocked ⛔, push again → Percy resumes.Check if PR is ready for release
N/A — no Vanilla SCSS or macro code changes (CI workflow only).
Screenshots
N/A