Repository navigation
test(cluster): cover the VM membership and RAFT recovery (4/7) - #358
Draft
marceloneppel wants to merge 1 commit into
Draft
marceloneppel wants to merge 1 commit into
marceloneppel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The membership and RAFT recovery slices need their unit coverage (the code slice precedes its tests, mirroring the logical-replication stack's 6/8 pattern).
Solution
tests/unit/test_cluster_membership.py: the defer-path guard (a deferred re-add never drops or duplicatesmembers_ips), departed early-exits, reconfigure/add-cluster-member flows,update_member_ipIP-change handling, and the RAFT recovery transitions — ports of the VM charm's test cases.Checklist