Repository navigation
[DPE-11045] test(logical-replication): cover the ported module (6/8) - #350
Draft
marceloneppel wants to merge 5 commits into
Draft
marceloneppel wants to merge 5 commits into
marceloneppel wants to merge 5 commits into
Conversation
marceloneppel
added this pull request to stack #351
October 7, 2026 22:40
This was referenced Oct 7, 2026
marceloneppel
force-pushed
the
lr-5b-unit-coverage
branch
from
October 8, 2026 04:01
042fc23 to
8d46a37
Compare
marceloneppel
force-pushed
the
lr-5b-unit-coverage
branch
from
October 9, 2026 19:30
8d46a37 to
bceec2a
Compare
marceloneppel
force-pushed
the
lr-5b-unit-coverage
branch
from
October 9, 2026 19:44
bceec2a to
2b014c6
Compare
marceloneppel
force-pushed
the
lr-5b-unit-coverage
branch
from
October 9, 2026 20:22
2b014c6 to
8a58104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Sixth PR of the logical replication migration series (after #270; the restore-side guard follows in #338): the unit coverage for the ported module, split out of #270 so each PR stays under ~1000 changed lines.
Solution
tests/unit/test_logical_replication.py): chain building, subscriber and publisher circular checks, validation blocking, non-circular passing, and stale-error handling.create_subscriptionretry intests/unit/test_postgresql.py: create on the publisher, deterministic drops with walsender-race retries.synchronous_mode_strictgating test intests/unit/test_config_manager.py(strict mode only applied whencluster_initialised).logical-replicationrelations in the test-charm metadata and the combined VM test charm) - the harness cannot add those relations without it.Checklist