Repository navigation
Conversation
Collaborator
Author
|
Closing: the console capture served its purpose — it showed the runner VMs' SSH tunnel to the CI host timing out, which #427 fixes by replacing the tunnel with a tenant relay. Not needed as a permanent diagnostic for now. AI-generated message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
While the GARM E2E waits for a runner to register, it now snapshots the serial console of every running runner VM (Nova
os-getConsoleOutput, at most once a minute per VM). If no runner registers, it logs the last 300 lines of each VM's latest snapshot, redacted, next to the existing GARM debug dump.Why we need it
The nightly edge-to-candidate promotion has failed since 2026-10-08: runner VMs boot but never contact GARM. Only the VM console can show whether the callback tunnel came up or where cloud-init stopped, and GARM's bootstrap-timeout reaper deletes the VM before the test gives up. So the console has to be read while the VM is still up.
Test plan
tox -e charms-tests-unit: new model-free tests cover the fetch, throttling, error tolerance and redaction, plus the wait handing every poll to the recorder.garm_e2e.yamldispatch on this branch, to check the console shows up in a real failing run.Review focus
Bearer,--tokenandtoken=/token:patterns. GARM's install script only traces its tokens with boot debug on, so the patterns are defence in depth.requests, using theOS_*credentials the suite already has.Checklist
CONTRIBUTING.mdhas been updated upon changes to the contribution/development process (e.g. changes to the way tests are run)docs/changelog.mdwith user-relevant changesterraform fmtpasses andtflintreports no errorsAGENTS.md.copilot-collections.yamlor.github/instructions/: I re-checked whether theAGENTS.md"12-factor divergences" guidance still matches the upstream copilot-collections guidance