refactor: only register callback routes when their processor is active#597
Open
Anshumancanrock wants to merge 4 commits intocameri:mainfrom
Open
Conversation
🦋 Changeset detectedLatest commit: 6834e5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
coverage: 64.979% (+2.2%) from 62.753% — Anshumancanrock:refactor/callback-routes-conditional-registration into cameri:main |
Anshumancanrock
force-pushed
the
refactor/callback-routes-conditional-registration
branch
2 times, most recently
from
a6da7c6 to
ca9454e
Compare
Anshumancanrock
force-pushed
the
refactor/callback-routes-conditional-registration
branch
from
ca9454e to
4a932d4
Compare
cameri
approved these changes
May 3, 2026
cameri
reviewed
May 3, 2026
| const requireProcessor = (name: string) => | ||
| (_req: Request, res: Response, next: NextFunction) => { | ||
| const settings = createSettings() | ||
| if (settings.payments?.processor !== name) { |
Owner
There was a problem hiding this comment.
should we also check here if payments are enabled, not just which processor is configured?
Owner
|
PR title does not quite match the change: callbacks are always registered, but guarded by a reusable middleware that checks the payment processor is configured before allowing the request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
/callbacks/opennode,/callbacks/lnbits, and/callbacks/zebedeeroutes were always registered regardless of which payment processor was active. Each controller then had to checksettings.payments.processorand return 403 if it didn't match.This PR moves that check to the route layer so each route is now only registered when its processor is the configured one, the same way
/callbacks/nodelessworks after #584.Related Issue
Follows up on #584 (as approved by @cameri).
Motivation and Context
The in-controller processor check was redundant , if a route isn't registered, it can't be hit. Keeping dead routes open is unnecessary exposure, and the scattered
paymentProcessor !== 'x'checks were noise that could easily be missed when reading the controller logic.How Has This Been Tested?
test/unit/routes/callbacks.spec.tsto stubcreateSettingsso the OpenNode route registers correctly during the testScreenshots (if appropriate):
N/A
Types of changes
Checklist: