Skip to content

Various adjustments#134

Closed
johnshaughnessy wants to merge 26 commits into
c-frame:masterfrom
MozillaReality:hubs/master
Closed

Various adjustments#134
johnshaughnessy wants to merge 26 commits into
c-frame:masterfrom
MozillaReality:hubs/master

Conversation

@johnshaughnessy

Copy link
Copy Markdown

TODO: Update dist
TODO: Talk to @wmurphyrd and @InfiniteLee

@johnshaughnessy

Copy link
Copy Markdown
Author

Kevin will break this into his smaller PR's

@wmurphyrd

Copy link
Copy Markdown
Member

Most of the commits we're already in Kevin's other PR. I was going to shave off yours and apply them. I just finally got a release done last weekend, so I can start on these

@wmurphyrd wmurphyrd reopened this Jul 19, 2018
provides bindings for secondary activations while an object is being grabbed. configurable to allow specifying a specific button event, to allow you to have multiple activatable components on an object (this may not be the best way to do this)
…axGrabbers is reached.

Default is what it does now, which is nothing. Also added 'drop' which ends the grab with the the first hand currently grabbing so that the new hand can grab.
# Conflicts:
#	dist/super-hands.min.js
@InfiniteLee

InfiniteLee commented Jul 19, 2018

Copy link
Copy Markdown
Contributor

@wmurphyrd This includes #124 and #129 and now #148 and #149. #129 is technically behind this, but I was going to update it with @johnshaughnessy's changes. Do you want to use the individual PR's or this combined one? (I would probably suggest doing the individual ones since #148 and #149 are brand new, but needed to be landed in our dev fork which is why they appear in this PR now).

@InfiniteLee

Copy link
Copy Markdown
Contributor

#150 has been added, which is the one changeset that was missing its own PR that is currently combined into this one. So this PR is comprised of: #124 #129 #148 #149 and #150

@wmurphyrd

Copy link
Copy Markdown
Member

superseded by #150

@wmurphyrd wmurphyrd closed this Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants