fix the overflow at (https://github.com/c-cube/qcheck/issues/408)#410
Merged
Conversation
jmid
approved these changes
May 6, 2026
Collaborator
jmid
left a comment
jmid
left a comment
There was a problem hiding this comment.
This is excellent - thanks a bunch - also for adding a nice regression test! 🙏😃
Can you add a CHANGELOG entry, mentioning that the fix concerns an issue with both Test.make_{test,cell,...} - and in both QCheck and QCheck2?
alpaylan
force-pushed
the
fix/count-overflow
branch
from
9acc4cc to
31a57c0
Compare
Contributor
Author
|
Done, thank you for the kind comments! |
jmid
reviewed
May 6, 2026
alpaylan
force-pushed
the
fix/count-overflow
branch
from
31a57c0 to
97b291f
Compare
alpaylan
force-pushed
the
fix/count-overflow
branch
from
97b291f to
882ffa3
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I applied the suggested fix, added a regression test, ran and checked.