Update object dependency to 0.40.0 - #14096
Open
philipc wants to merge 1 commit into
Open
Conversation
philipc
commented
Aug 9, 2026
| /// Pulley target, for example, to indicate that it does not need to be made | ||
| /// natively executable as it does not contain actual native code. | ||
| pub const SH_WASMTIME_NOT_EXECUTED: u64 = 1 << 0; | ||
| pub const SH_WASMTIME_NOT_EXECUTED: object::elf::SectionFlags = object::elf::SectionFlags(1 << 0); |
Contributor
Author
There was a problem hiding this comment.
Note that this has the same value as SHF_WRITE, so this happens to work for .text sections, but seems like it was only by chance. I'm not sure which bit would be better though (if we use an OS or PROC bit then probably the reader side would need an additional OS or machine check too).
github-actions
Bot
added
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have a need for this; I'm just fixing things that I broke in this release.