Repository navigation
Conversation
Outer aliases now print the same identifier as the header of the component they refer to, or its count when a scope in between has the same identifier. They printed the target's name with its `(@name ...)` annotation, which only parses where the component is defined; they used a nested component's own name from its `component-name` section, while its header uses the name its parent gives it; and they printed identifiers that an inner scope shadows, such as the synthetic `$"#component0 "` of both a component and its first nested component, so the printed text didn't parse or referred to the wrong scope. (component (@name "") (type u8) (alias outer 0 0 (type))) printed `(alias outer $"#component0 " (@name "") 0 (type))`.
jrandolf
force-pushed
the
wasmprinter-outer-alias-names
branch
from
October 23, 2026 23:52
6f556a1 to
a949791
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outer aliases now print the same identifier as the header of the component they refer to, or the alias's count when a scope in between has the same identifier. In three cases, the printed text of a valid component didn't parse or referred to the wrong scope:
(@name ...)annotation, which only parses where the component is defined.(component (@name "") (type u8) (alias outer 0 0 (type)))printed(alias outer $"#component0 " (@name "") 0 (type)).component-namesection, so it could refer to an identifier that nothing defines.$"#component0 ", for example.These were found by the grammar-based component fuzzer in #2796.