Repository navigation
mutate: Don't reorder, drop or duplicate effectful operands - #2775
Conversation
|
I commented a bit more here, but I think this is a bit too much for me to take on in reviewing personally at least. @fitzgen if you'd like I'll leave you assigned, but again I'll caution you @tamaroning that |
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
Thanks for the PR.
As Alex said, wasm-mutate is not in the best spot right now and is definitely lacking polish and love. I'd like to half-rewrite/half-port it over to mutatis (see also this blog post) at some point in time, and I think the peephole stuff needs to be pretty much completely overhauled, but that's pretty far down my never-ending list of TODOs.
I think the best thing that can be done for it until then is probably just making it better for the purposes of wasm-tools shrink (i.e. focusing on non-semantics preserving mutations that help reduce test cases).
Fix #2767