Skip to content

Allow github.run_id in workflow concurrency groups - #613

Merged
sj26 merged 1 commit into
mainfrom
pb-3721-workflow-concurrency-run-id
Oct 21, 2026
Merged

sj26 merged 1 commit into
mainfrom
pb-3721-workflow-concurrency-run-id

Conversation

@sj26

@sj26 sj26 commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Why

Workflow concurrency rejects a build-scoped group even though the runtime already exposes the Buildkite build ID:

concurrency:
  group: codeql-${{ github.run_id }}

This currently fails with compile-time expression references unavailable value "github.run_id".

What

Hosted upload now resolves that group to codeql-<Buildkite build ID>. Repeated imports in the same build retain the group; different builds get different groups. A separate workflow-concurrency profile keeps other import-time expression limits unchanged.

Offline validation and compilation still require a real build identity instead of inventing an ID. Their diagnostic suggests hosted upload or a branch-scoped group using github.workflow and github.ref.

Adds workflow concurrency to the native expression oracle. The pinned GitHub run passed, and companion docs record the evidence and unreleased boundary.

Related: PB-3721. The reported production diagnostic is confirmed, but the original customer workflow and event remain inaccessible; the local reproduction is a separate minimal fixture.

buildsworth-bk-app[bot]
buildsworth-bk-app Bot previously approved these changes Oct 21, 2026
Keep run identity scoped to workflow concurrency and require explicit build identity outside hosted upload.

Amp-Thread-ID: https://ampcode.com/threads/T-55f7b774-50aa-497e-a379-7a39c0cfed07
Co-authored-by: Amp <amp@ampcode.com>
@sj26
sj26 force-pushed the pb-3721-workflow-concurrency-run-id branch from c458fb4 to fc82d36 Compare October 21, 2026 04:04
@buildsworth-bk-app
buildsworth-bk-app Bot dismissed their stale review October 21, 2026 04:06

Superseded by a newer Buildsworth review.

@sj26
sj26 merged commit cf26f60 into main Oct 21, 2026
8 checks passed
@sj26
sj26 deleted the pb-3721-workflow-concurrency-run-id branch October 21, 2026 04:17

zhming0 commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Released in v0.106.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants