Properly deal with the instance name being empty#28
Merged
Conversation
Right now it accepts any string. I don't think we should support exactly the same format as REv2, but it would be a good idea to have some restrictions on it, so that it's at least permitted to embed them into file system pathnames.
We want them to be path-like, similar to what REv2 has. However, we don't want the format to be as liberal. Though at the same time we don't want to go the REv2 approach where we need to have a hardcoded list of forbidden words.
EdSchouten
force-pushed
the
eschouten/20260610-instance-name
branch
from
June 10, 2026 12:36
84ba4ad to
f3a78aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up to this point we didn't attempt to add any structure to instance names, for the reason that REv2's format has some warts, like requiring us to keep certain keywords reserved. Let's come up with a more sensible format. While there, fix the issue that using the empty instance name would result in incorrect bonanza_browser URLs.
Fixes: #26
Fixes: #27