Support FUSE on FreeBSD, and get rid of local patches#239
Merged
Conversation
Closed
EdSchouten
force-pushed
the
eschouten/20260627-fuse
branch
from
00f1b48 to
f480f77
Compare
EdSchouten
force-pushed
the
eschouten/20260627-fuse
branch
3 times, most recently
from
f03bae9 to
4ab54d7
Compare
The updated patches passes `go test ./...` in the go-fuse code base.
EdSchouten
force-pushed
the
eschouten/20260627-fuse
branch
from
4ab54d7 to
a310e23
Compare
In the past, Han-Wen indicated that he'd rather not make backward incompatible changes to the RawFileSystem interface. This means that holding on to these patches ourselves is futile. It only makes it harder for people to build our VFS API outside of Bazel. Let's add our own RawFileSystem interface that mirrors the one provided by go-fuse. We can then change the Init(), ReadDir(), and ReadDirPlus() methods any way we want.
EdSchouten
force-pushed
the
eschouten/20260627-fuse
branch
from
a310e23 to
ce8c507
Compare
Let me build the binaries and test this afternoon. |
|
@moroten good to merge. I have successful builds on this branch. |
Member
Author
|
Thanks for checking! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @moroten and @b3cramer,
Looking at #238, I thought we might as well tidy up things a bit further, so that we need fewer local patches. Can you PTAL at this change and let me know whether it's fine to merge? Thanks!
Fixes: #238