fix: simplify WASM marimo smoke test (approach C)#526
Closed
paddymul wants to merge 2 commits into
Closed
Conversation
The previous test waited for .buckaroo_anywidget and .ag-cell elements, which never render in the Pyodide/WASM environment. This replaces it with a smoke test that verifies: 1. Marimo WASM page loads (Pyodide initializes) 2. Cells execute and produce output (no error banners) 3. Expected markdown content appears Also increases test timeout to 120s for slow Pyodide initialization. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Closing in favor of #532 (uses real Pyodide-bundled fastparquet) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.buckaroo_anywidgetand.ag-cell(which never render in Pyodide/WASM)Details
Investigation showed that in marimo's WASM/Pyodide environment, only markdown cells produce visible output. The BuckarooWidget cells execute but don't render
.buckaroo_anywidgetor AG-Grid elements in the DOM. The previous test was doomed to always timeout.The new test checks three reliable signals:
waitForFunctionuntil "Buckaroo in Marimo WASM" text appears (proves Pyodide loaded and cells executed).marimo-celland.output-areaelement exists[role="alert"]error bannersTest plan
🤖 Generated with Claude Code