Skip to content

Fix colors on Qt 6.12 - #20

Merged
btsouth merged 1 commit into
mainfrom
fix/qt612-color
Oct 9, 2026
Merged

btsouth merged 1 commit into
mainfrom
fix/qt612-color

Conversation

@btsouth

@btsouth btsouth commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

Qt 6.12 adds a QtQuick Color type that hides the shell's Color singleton, so colors came out undefined on updated systems. This qualifies every reference as Commons.Color, the same fix Omarchy made in omacom/omarchy#14553, and bumps to 1.11.2.

Tested in an omabox desktop on Qt 6.12.0 and Omarchy r6815: the plugin loads and its panel opens with no QML errors. Also ran the unit tests.

Summary by CodeRabbit

  • Bug Fixes
    • Restored theme colors on Qt 6.12, including panel and source dropdown colors.
  • Documentation
    • Updated release references to version 1.11.2.

Qt 6.12 adds a QtQuick Color type that hides the Commons Color singleton,
so every bare Color.x came out undefined. Qualify the references the same
way Omarchy did for its own shell (omacom/omarchy#14553).
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8048016f-aac9-4679-8e32-6e798bd2a9a9
📥 Commits

Reviewing files that changed from the base of the PR and between feb345d and a892c9b.

📒 Files selected for processing (7)
  • CHANGELOG.md
  • README.md
  • VERSION
  • docs/installation.md
  • plugin/Panel.qml
  • plugin/SourceDropdown.qml
  • plugin/manifest.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The plugin now qualifies shell palette references as Commons.Color in Panel.qml and SourceDropdown.qml. Release metadata and installation examples identify version 1.11.2. The changelog records the Qt 6.12 color correction.

Changes

Plugin color references and release update

Layer / File(s) Summary
Qualify plugin palette color references
plugin/Panel.qml, plugin/SourceDropdown.qml
Both QML files import the Commons namespace and use Commons.Color for palette references.
Update release version and notes
VERSION, plugin/manifest.json, README.md, docs/installation.md, CHANGELOG.md
The release version and documented pins change to 1.11.2. The changelog describes the Qt 6.12 color correction.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to a892c

The change aims to restore shell colors on Qt 6.12. The PR reports a successful runtime load, and the available evidence establishes no concrete failure or merge blocker.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: fixing color handling for Qt 6.12.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@btsouth
btsouth merged commit 1f08b68 into main Oct 9, 2026
5 checks passed
@btsouth
btsouth deleted the fix/qt612-color branch October 9, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant