Repository navigation
Fix colors on Qt 6.12 - #20
Conversation
Qt 6.12 adds a QtQuick Color type that hides the Commons Color singleton, so every bare Color.x came out undefined. Qualify the references the same way Omarchy did for its own shell (omacom/omarchy#14553).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe plugin now qualifies shell palette references as ChangesPlugin color references and release update
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change aims to restore shell colors on Qt 6.12. The PR reports a successful runtime load, and the available evidence establishes no concrete failure or merge blocker. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Qt 6.12 adds a QtQuick
Colortype that hides the shell'sColorsingleton, so colors came out undefined on updated systems. This qualifies every reference asCommons.Color, the same fix Omarchy made in omacom/omarchy#14553, and bumps to 1.11.2.Tested in an omabox desktop on Qt 6.12.0 and Omarchy r6815: the plugin loads and its panel opens with no QML errors. Also ran the unit tests.
Summary by CodeRabbit