Skip to content

Take .github's CONTRIBUTING shared part (issue btclib-org/.github#2088) - #477

Merged
fametrano merged 1 commit into
mainfrom
iss-2088-contributing-shared
Nov 7, 2026
Merged

fametrano merged 1 commit into
mainfrom
iss-2088-contributing-shared

Conversation

@fametrano

Copy link
Copy Markdown
Member

Everything in CONTRIBUTING.md above This repository in particular is taken byte for byte from btclib-org/.github main (9d6c5fe), which PR btclib-org/.github#2095 changed. Working with an LLM gains the sentence that the maintainer who lands an agent's pull request through the bypass, without an approval, reads every line and answers for it, the landing being their own act. It also names the alternative set aside: an approval required even where the bypass is kept. That landing stands beside the approval as the certification.

This tree's own part, from that heading on, is unchanged.

Evidence

what result
shared part sha256 of the bytes before ## This repository in particular (as verbatim_test.py splits them) is fab8c08348926536, equal to btclib-org/.github main's; the own part is this tree's
gates on 4ed2e12 pre-commit run --all-files 0; where CONTRIBUTING.md feeds the docs, sphinx-build -n -W 0; the tests that read CONTRIBUTING.md, where this tree has them, 0
merge-tree clean on origin/main
local review dedicated reviewer CLEARED 4ed2e12
fresh review not run: codex exec refused with "ERROR: Your workspace is out of credits. Add credits to continue." (17:56 CET, 2026-11-06), so the rounds ended at the dedicated reviewer's CLEARED

One of fifteen trees carrying ISS btclib-org/.github#2088; .github drops the recorded drift after all fifteen land.

🤖 Generated with Claude Code

Everything in CONTRIBUTING.md above *This repository in particular* is
taken byte for byte from btclib-org/.github, as ISS
btclib-org/.github#2088 asks. *Working with an LLM* gains the sentence
that the maintainer who lands an agent's pull request through the
bypass, without an approval, reads every line and answers for it, the
landing being the maintainer's own act, and names the alternative set
aside. That landing stands beside the approval as the certification.
This tree's own part is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ferdinando Ametrano <ferdinando@ametrano.net>
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Updated pull request guidance to clarify that maintainers who land an agent-opened contribution without approval are responsible for reviewing every line.
    • Clarified that the DCO certification applies when a contribution is approved or landed by a maintainer.

CONTRIBUTING.md now describes maintainer responsibility when an agent-opened pull request is landed through the approval bypass without approval. It also states that either approval or the maintainer’s landing certifies the DCO statement.

Changes: Agent PR landing guidance

Layer / File(s) Summary
Maintainer responsibility and DCO certification
CONTRIBUTING.md
The guidance states that a maintainer who lands an agent-opened pull request without approval reads every line and answers for it. It identifies requiring approval despite the bypass as the alternative, and updates DCO certification to cover approval or the maintainer’s landing.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Possibly related PRs

  • btclib-org/ecc#468: Establishes approval of an agent-opened pull request as DCO certification and assigns responsibility to the approver.
Merge Risk: Minimal · up to 4ed2e

The guidance clarifies maintainer responsibility for bypassed approvals. No merge-blocking issue was identified.

Security architecture risk: Minimal · up to 4ed2e

The change explicitly assigns line-by-line responsibility to the maintainer using an existing merge bypass. It does not introduce that bypass, expand merge privileges, or remove an existing approval requirement. No material security risk was found to be introduced or worsened.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The introduced effect is limited to documented responsibility for maintainer merge decisions. The comparison supplies no change granting additional authority to automated contributors or changing executable merge controls.

Trust Boundaries and Controls

  • observed — The unchanged landing instructions already describe a maintainer bypass that can skip approval and required checks. They also require both ordinary and bypass merges to pin the reviewed head, refusing a merge if that head moves. These are documented controls and exceptions, not independently verified live settings.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title describes the shared CONTRIBUTING.md update and cites the tracking issue in the required form. (github.com)
Description check Passed The description matches the CONTRIBUTING.md changes.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Usage-based review receipt

  • Mode: Continue automatically
  • Reviewed files: 1
  • Waived: $0.25 (charged $0.00)
  • View usage details

Note

This review exceeded your plan’s limits and used usage-based reviews—free during trial, billed after paid activation unless disabled. Manage usage-based reviews.

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d83ebfd and 4ed2e12.

Files selected for processing: 1

  • CONTRIBUTING.md

Limit details: You’ve used all 10 included reviews currently available.

@read-the-docs-community

Copy link
Copy Markdown

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4ed2e12

@fametrano fametrano mentioned this pull request Nov 6, 2026
@fametrano
fametrano merged commit 1a81844 into main Nov 7, 2026
22 checks passed
@fametrano
fametrano deleted the iss-2088-contributing-shared branch November 7, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant