Repository navigation
Conversation
StarNet++ v2.5.x requires GLIBC_2.38 and GLIBCXX_3.4.32 which debian:bookworm-slim does not ship. Ubuntu 24.04 (noble) provides both. Changes: - Add ubuntu-noble case to the runtime apt-get install dispatch (libraw23t64, libwcs8, libcurl4t64, libcfitsio10t64, libopencv-core406t64) - Inline CRLF fix for entrypoint.sh so Windows git clones work without the "bash\r: No such file or directory" error at container startup - Keep debian:bookworm-slim and ubuntu-jammy paths unchanged The default BASE arg stays debian:bookworm-slim; Ubuntu 24.04 is opt-in: docker build --build-arg BASE=ubuntu:24.04 -t astrolab:noble . Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an
ubuntu-noblecase to the runtimeapt-get installdispatch so the image can be built on Ubuntu 24.04. Also inline the CRLF fix forentrypoint.shso Windows git clones work out of the box.The motivation is StarNet++ v2.5.x: it requires
GLIBC_2.38/GLIBCXX_3.4.32whichdebian:bookworm-slimdoes not provide. Ubuntu 24.04 ships GLIBC 2.39 natively.The default
BASEarg is unchanged (debian:bookworm-slim). Ubuntu 24.04 is opt-in:docker build --build-arg BASE=ubuntu:24.04 -t astrolab:noble .Test plan
pytest tests/passes locally — 674/682 tests pass; 8 pre-existing failures unrelated to this PR:test_orphan_master_removed(timing bug confirmed on upstreamfcb1243), 2xtest_scanner_orphans(Windows path-separator bug in_remove_orphans, only visible without -x), 5xtest_siril_runtime(no Siril binary on Windows dev machine)npm run checkclean fromui/— 0 errors; 3 pre-existing CSS warnings inplayground/themes(unrelated)ubuntu:24.04baseNotes for the reviewer
Package name differences on noble vs bookworm:
libraw23t64,libwcs8,libcurl4t64,libcfitsio10t64,libopencv-core406t64(Ubuntu renamed several packages with thet64suffix for 64-bit time_t transition). The existingdebian-bookwormandubuntu-jammypaths are untouched.