Skip to content

Add imagecodecs to venv for LZW TIFF support in starnet_extract - #190

Open
Thundras wants to merge 1 commit into
bscholer:mainfrom
Thundras:fix/imagecodecs-lzw
Open

Thundras wants to merge 1 commit into
bscholer:mainfrom
Thundras:fix/imagecodecs-lzw

Conversation

@Thundras

@Thundras Thundras commented Aug 28, 2026 •

Copy link
Copy Markdown

Summary

Install imagecodecs into the venv after uv sync so tifffile can decode the LZW-compressed TIFFs that StarNet++ v2.5 writes. Without it the pipeline fails with ValueError: <COMPRESSION.LZW: 5> requires the 'imagecodecs' package.

Test plan

  • pytest tests/ passes locally — 674/682 tests pass; 8 pre-existing failures unrelated to this PR: test_orphan_master_removed (timing bug confirmed on upstream fcb1243), 2x test_scanner_orphans (Windows path-separator bug in _remove_orphans, only visible without -x), 5x test_siril_runtime (no Siril binary on Windows dev machine)
  • npm run check clean from ui/ — 0 errors; 3 pre-existing CSS warnings in playground/themes (unrelated)
  • Manually exercised the affected flow in the browser — starnet_extract reads the StarNet++ output TIFF without error
  • N/A — explain why

Notes for the reviewer

uv pip install runs after uv sync --frozen so the lock file is not modified. An alternative would be adding imagecodecs to pyproject.toml and regenerating uv.lock, but that touches a file many contributors share and this keeps the diff minimal.

StarNet++ writes LZW-compressed TIFFs; tifffile raises ValueError
(<COMPRESSION.LZW: 5> requires the 'imagecodecs' package) when reading
them back. Install imagecodecs into the existing venv after the frozen
uv sync so the lock file stays untouched.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant