Repository navigation
Conversation
StarNet++ writes LZW-compressed TIFFs; tifffile raises ValueError (<COMPRESSION.LZW: 5> requires the 'imagecodecs' package) when reading them back. Install imagecodecs into the existing venv after the frozen uv sync so the lock file stays untouched. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Install
imagecodecsinto the venv afteruv syncsotifffilecan decode the LZW-compressed TIFFs that StarNet++ v2.5 writes. Without it the pipeline fails withValueError: <COMPRESSION.LZW: 5> requires the 'imagecodecs' package.Test plan
pytest tests/passes locally — 674/682 tests pass; 8 pre-existing failures unrelated to this PR:test_orphan_master_removed(timing bug confirmed on upstreamfcb1243), 2xtest_scanner_orphans(Windows path-separator bug in_remove_orphans, only visible without -x), 5xtest_siril_runtime(no Siril binary on Windows dev machine)npm run checkclean fromui/— 0 errors; 3 pre-existing CSS warnings inplayground/themes(unrelated)starnet_extractreads the StarNet++ output TIFF without errorNotes for the reviewer
uv pip installruns afteruv sync --frozenso the lock file is not modified. An alternative would be addingimagecodecstopyproject.tomland regeneratinguv.lock, but that touches a file many contributors share and this keeps the diff minimal.