Accept Chrome recorder JSON without a trailing extract step - #173
Open
cheos71 wants to merge 1 commit into
Open
Conversation
The side-panel download ends on click/input and uses targetText, so run-workflow-no-ai could not load its own recordings. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
click/inputand usetargetText.WorkflowDefinitionSchemarejected those files, sorun-workflow-no-aicould not load a recording it just produced.run-as-tool, not a recorder requirement).targetTextas an alias fortarget_textso semantic replay sees the captured label.Test plan
targetText) viaWorkflowDefinitionSchema.model_validatetarget_textsnake_case still loadspython cli.py run-workflow-no-ai path/to/sidepanel-download.jsonon a recording that was not manually given an extract stepMade with Cursor
Summary by cubic
Fixes loading of Chrome recorder JSON exports so
run-workflow-no-aican replay recordings that end on click/input instead of extract. Now acceptstargetTextas an alias fortarget_text.run-as-tool.Written for commit 5fdae8b. Summary will update on new commits.