Skip to content

add agent guidance, comment convention, and skill contract guards - #145

Open
DonIsmaelito wants to merge 9 commits into
browser-use:mainfrom
DonIsmaelito:feature/agent-guidance-and-guards
Open

add agent guidance, comment convention, and skill contract guards#145
DonIsmaelito wants to merge 9 commits into
browser-use:mainfrom
DonIsmaelito:feature/agent-guidance-and-guards

Conversation

@DonIsmaelito

@DonIsmaelito DonIsmaelito commented Sep 2, 2026

Copy link
Copy Markdown

Adds AGENTS.md so coding agents know the repo's rules, puts a short plain comment above every function in the existing helpers, and adds two tests: one that keeps the comment convention, one that keeps SKILL.md's numbered hard rules in order and checks every path it references exists. Also a pytest path setting so plain pytest works, and a one-line fix in the timeline PNG export.


Summary by cubic

Adds repo guidance and contract guards so concurrent agents can work safely without silently breaking the public editing rules. It also standardizes Python definition comments and fixes timeline PNG extraction compatibility.

  • AGENTS.md documents product principles, architecture boundaries, workflow, and branch discipline.
  • Every Python file now requires a module docstring and plain comment text above each function or class, enforced by tests/test_comment_style.py.
  • tests/test_skill_contract.py verifies numbered hard rules stay in order and every referenced path or helper script exists.
  • Adds a pytest pythonpath setting so plain pytest works from the repo root.
  • Timeline PNG extraction now forces the yuvj420p pixel format.

Written for commit b48e603. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 12 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread tests/test_comment_style.py Outdated
Comment thread tests/test_skill_contract.py
Comment thread AGENTS.md Outdated
Comment thread tests/test_comment_style.py Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread tests/test_comment_style.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant