fix: make helper output safe on non-UTF-8 consoles - #144
Open
motodriver wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Author
|
Addressed both review findings in ef03684:
Validation:
|
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Author
|
Addressed the latest P2 review finding in 28abe48. The regression now executes each helper's actual CLI entry point with Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
python3 -m unittest discover -s tests -v(17 tests passed)python3 -m py_compile helpers/render.py helpers/grade.py helpers/pack_transcripts.py helpers/transcribe_batch.py tests/test_stdout_encoding.pygit diff --checkAI assistance disclosure
TRAE assisted with issue analysis, implementation, regression-test drafting, and an independent P0-P2 review of this change. The human author reviewed the final diff and ran the validation commands listed above.
Closes #125
Summary by cubic
Fixes helper scripts crashing on non-UTF-8 consoles by reconfiguring stdout to UTF-8 with replacement. Redirected output now shows progress glyphs instead of failing.
Closes #125.
Written for commit 28abe48. Summary will update on new commits.