brainglobe-atlasapi V3 compatibility - #282
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the napari registration plugin to populate the atlas dropdown using brainglobe_atlasapi.list_atlases.get_all_atlases_lastversions() (to support brainglobe-atlasapi v3 behavior), and adjusts the napari workflow test to explicitly select example_mouse_100um to avoid relying on dropdown default ordering.
Changes:
- Replace the previous remote-config atlas listing logic with
get_all_atlases_lastversions()in the napari plugin. - Update the napari integration workflow test to set the atlas explicitly to
example_mouse_100um.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| brainreg/napari/register.py | Switch atlas list source used to build the dropdown to get_all_atlases_lastversions(). |
| tests/test_brainreg_napari.py | Explicitly selects example_mouse_100um in the napari workflow test to stabilize expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adamltyson
approved these changes
Jul 21, 2026
IgorTatarnikov
changed the title
brainglobe-atlasapi V3 compatibility
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
See #280
What does this PR do?
Change the way available atlases are fetched for the dropdown to use
get_all_atlases_last_versions().Sets
aiobotocoreandbotocoredebugging level to INFO.Ensures the
example_mouse_100umis used for testing.References
Closes #280
How has this PR been tested?
Tested locally with
brainglobe-atlasapi==3.0.0rc1andbrainglobe-atlasapi==2.3.1. All tests pass.Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: