Refactor methods related to localized strings in Date#5411
Open
Vellumic wants to merge 8 commits into
Open
Conversation
DateDate
Test262 conformance changes
Tested main commit: |
505df58 to
a8b8216
Compare
DateDate
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5411 +/- ##
===========================================
+ Coverage 47.24% 60.34% +13.10%
===========================================
Files 476 567 +91
Lines 46892 63112 +16220
===========================================
+ Hits 22154 38086 +15932
- Misses 24738 25026 +288 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring of the logic added by 26271b7. This PR is a prerequisite for #5199
It changes the following:
toLocaleString,toLocaleDateString, andtoLocaleTimeStringformat_date_time_localeas unnecessaryTesting:
cargo test -p boa_engine --lib -- date::tests::date_proto_to_locale_string_intl(skipped)cargo test -p boa_engine --features intl_bundled --lib -- date::tests::date_proto_to_locale_string_intl(passed)