Skip to content

Align Intl.DateTimeFormat constructor with spec-mandated initialization order#5336

Open
Vellumic wants to merge 1 commit into
boa-dev:mainfrom
Vellumic:fix/intl-dtf-ctor-observable-behavior
Open

Align Intl.DateTimeFormat constructor with spec-mandated initialization order#5336
Vellumic wants to merge 1 commit into
boa-dev:mainfrom
Vellumic:fix/intl-dtf-ctor-observable-behavior

Conversation

@Vellumic

@Vellumic Vellumic commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

This Pull Request fixes/closes #5335.

It changes the following:

  • Swap the prototype lookup and DateTimeFormat creation to match the spec steps order
  • Add a regression test for this specific case
  • Add a step 1 from spec to create_date_time_format as well as comment about why it's missing

Validation

  • Run (all passed)
cargo test --package boa_engine --lib --features intl_bundled -- builtins::intl::date_time_format::tests --nocapture

@github-actions github-actions Bot added Waiting On Review Waiting on reviews from the maintainers C-Tests Issues and PRs related to the tests. C-Builtins PRs and Issues related to builtins/intrinsics C-Intl Changes related to the `Intl` implementation labels Apr 15, 2026
@github-actions github-actions Bot added this to the v1.0.0 milestone Apr 15, 2026
@github-actions

github-actions Bot commented Apr 15, 2026

Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,072 51,072 0
Ignored 1,482 1,482 0
Failed 571 571 0
Panics 0 0 0
Conformance 96.14% 96.14% 0.00%

Tested main commit: 7ce9cae84ac9bf54fe528bb05b997ac24af808a4
Tested PR commit: 7d4e6c3a0d5208a0f4343acb1396e52016608b20
Compare commits: 7ce9cae...7d4e6c3

@codecov

codecov Bot commented Apr 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.35%. Comparing base (6ddc2b4) to head (7d4e6c3).
⚠️ Report is 982 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5336       +/-   ##
===========================================
+ Coverage   47.24%   60.35%   +13.10%     
===========================================
  Files         476      567       +91     
  Lines       46892    63149    +16257     
===========================================
+ Hits        22154    38113    +15959     
- Misses      24738    25036      +298     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Vellumic Vellumic changed the title Align Intl.DateTimeFormat constructor with spec-mandated initialization order Align Intl.DateTimeFormat constructor with spec-mandated initialization order Apr 15, 2026
@Vellumic Vellumic force-pushed the fix/intl-dtf-ctor-observable-behavior branch from a3edd2f to 7db4972 Compare June 18, 2026 03:00
@Vellumic

Copy link
Copy Markdown
Contributor Author

Hi everyone! Just wanted to gently bump this PR. Let me know if you need any changes or refactoring from my side. Thanks!

@Vellumic Vellumic force-pushed the fix/intl-dtf-ctor-observable-behavior branch from 7db4972 to 7d4e6c3 Compare June 19, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics C-Intl Changes related to the `Intl` implementation C-Tests Issues and PRs related to the tests. Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intl.DateTimeFormat constructor breaks the inheritance when passing wrong options

1 participant