Align Intl.DateTimeFormat constructor with spec-mandated initialization order#5336
Open
Vellumic wants to merge 1 commit into
Open
Align Intl.DateTimeFormat constructor with spec-mandated initialization order#5336Vellumic wants to merge 1 commit into
Intl.DateTimeFormat constructor with spec-mandated initialization order#5336Vellumic wants to merge 1 commit into
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5336 +/- ##
===========================================
+ Coverage 47.24% 60.35% +13.10%
===========================================
Files 476 567 +91
Lines 46892 63149 +16257
===========================================
+ Hits 22154 38113 +15959
- Misses 24738 25036 +298 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Intl.DateTimeFormat constructor with spec-mandated initialization orderIntl.DateTimeFormat constructor with spec-mandated initialization order
a3edd2f to
7db4972
Compare
Contributor
Author
|
Hi everyone! Just wanted to gently bump this PR. Let me know if you need any changes or refactoring from my side. Thanks! |
7db4972 to
7d4e6c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #5335.
It changes the following:
DateTimeFormatcreation to match the spec steps ordercreate_date_time_formatas well as comment about why it's missingValidation