Skip to content

fix: shelley systemStart must match the shifted byron startTime (devnet Plutus clock skew) #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nau wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: shelley systemStart must match the shifted byron startTime (devnet Plutus clock skew) #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...ions/cli/src/main/java/com/bloxbean/cardano/yacicli/localcluster/ClusterStartService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,10 +436,16 @@ private boolean setupFirstRun(ClusterInfo clusterInfo, Path clusterFolder, Consu
jsonNode.set("startTime", new LongNode(byronStartTime));
objectMapper.writer(new DefaultPrettyPrinter()).writeValue(byronGenesis.toFile(), jsonNode);

//Update Shelley Genesis file
//Update Shelley Genesis file. Use byronStartTime (not Instant.now()) so both genesis
//files describe the same chain origin: the node derives its slot counter from byron
//`startTime` but translates slots to POSIXTime in the Plutus script context from shelley
//`systemStart`. When shiftStartTimeBehind backdates the byron start and shelley stays at
//"now", the two clocks disagree by the backdate (one epoch, 600s by default) and every
//POSIXTime a Plutus script sees in `txInfoValidRange` is shifted by that amount against
//the slots the transaction was built with.
ObjectNode shelleyJsonNode = (ObjectNode) objectMapper.readTree(shelleyGenesis.toFile());
DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss'Z'");
String shelleyStart = formatter.format(Instant.now().atZone(ZoneOffset.UTC));
String shelleyStart = formatter.format(Instant.ofEpochSecond(byronStartTime).atZone(ZoneOffset.UTC));
shelleyJsonNode.set("systemStart", new TextNode(shelleyStart));
objectMapper.writer(new DefaultPrettyPrinter()).writeValue(shelleyGenesis.toFile(), shelleyJsonNode);

Expand Down