Add bound parameter support to fdb push writes#6015
Open
emelialei88 wants to merge 1 commit into
Open
Conversation
emelialei88
force-pushed
the
feat/fdb-push-write-bind-param
branch
from
0b5ff3e to
7dac30d
Compare
roborivers
suggested changes
Jun 9, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**
sql_logfill_autodisable [timeout]
dorinhogea
requested changes
Jun 10, 2026
dorinhogea
left a comment
dorinhogea
left a comment
Contributor
There was a problem hiding this comment.
Please check:
Line 809 in bbf138c
It frees fdb_push object and its remotedb, but not the new param object that is leaked0
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
emelialei88
force-pushed
the
feat/fdb-push-write-bind-param
branch
from
7dac30d to
fd257b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
@bindparameters tofdb_push.testCDB2_INTEGER,CDB2_REAL,CDB2_CSTRING