Skip to content

feat: support transaction cursor pagination - #68

Merged
vladimirvolek merged 2 commits into
masterfrom
codex/from-to-pagination
Jul 29, 2026
Merged

feat: support transaction cursor pagination#68
vladimirvolek merged 2 commits into
masterfrom
codex/from-to-pagination

Conversation

@slowbackspace

@slowbackspace slowbackspace commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds cursor-based (block range) filtering for transaction-list endpoints while ensuring cursor query parameters are retained during multi-page “fetch all” pagination.

Changes:

  • Introduces CursorPagination with from/to (inclusive) cursor builders on Pagination.
  • Adds cursor query parameter support to account/address/asset transaction endpoints.
  • Updates URL batch generation to preserve non-pagination query parameters (e.g., from/to) across pages and adds unit tests + changelog entry.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/url.rs Adds cursor-aware URL builder and preserves extra query params in generate_batch (plus tests).
src/pagination.rs Adds CursorPagination and Pagination::{with_from,with_to,with_range} helpers (plus tests).
src/lib.rs Re-exports CursorPagination from the crate root.
src/api/mod.rs Adds internal call_cursor_paged_endpoint and a test ensuring cursor params are sent.
src/api/endpoints/assets.rs Updates asset transactions endpoint to accept cursor pagination.
src/api/endpoints/addresses.rs Updates address transactions endpoint to accept cursor pagination.
src/api/endpoints/accounts.rs Updates account transactions endpoint to accept cursor pagination.
CHANGELOG.md Documents the added cursor support.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/api/endpoints/accounts.rs
Comment thread src/api/endpoints/addresses.rs
Comment thread src/api/endpoints/assets.rs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

CHANGELOG.md:14

  • The PR description mentions adding a CursorPagination type, but the implementation (and this changelog entry) extends Pagination with from/to and introduces BlockCursor. Please update the PR description to match the actual API changes (or rename/introduce the described type) to avoid confusion for reviewers and release notes consumers.
### Added

- `Pagination::with_from`, `Pagination::with_to` and `Pagination::with_range` for inclusive `from`/`to`
  block cursors, plus the `BlockCursor` type they take
- Cursors are only sent by the three endpoints that accept them (`accounts_transactions`,

@vladimirvolek
vladimirvolek merged commit 740d30c into master Jul 29, 2026
5 checks passed
@vladimirvolek
vladimirvolek deleted the codex/from-to-pagination branch July 29, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants