Skip to content

[PM-36421] Add xmldoc to Admin Console entities - #7580

Merged
eliykat merged 4 commits into
mainfrom
ac/pm-36421/beeep-add-xmldoc-to-admin-console-entities
May 6, 2026
Merged

eliykat merged 4 commits into
mainfrom
ac/pm-36421/beeep-add-xmldoc-to-admin-console-entities

Conversation

@eliykat

@eliykat eliykat commented May 5, 2026 •

Copy link
Copy Markdown
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-36421

📔 Objective

Add xmldoc to AC Team entity models. This is a chore and some of it is rote, but there's useful and important stuff in there - e.g. how collection access assignments work, that the organization Identifier is the SSO identifier, what the collection management settings do.

📸 Screenshots

@eliykat
eliykat requested a review from a team as a code owner May 5, 2026 04:30
@eliykat eliykat added the ai-review Request a Claude code review label May 5, 2026
@eliykat
eliykat requested a review from JaredScar May 5, 2026 04:30
@github-actions

github-actions Bot commented May 5, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Documentation-only PR adding XML doc comments to Admin Console entity models (Collection, CollectionGroup, CollectionUser, Group, GroupUser, Organization, OrganizationInviteLink, Policy, Provider, ProviderOrganization, ProviderUser) and the related Models/Data collection access types. The changes are purely additive documentation with no behavioral or runtime impact. Removing the per-file #nullable enable directives is safe because <Nullable>enable</Nullable> is set at the project level in Directory.Build.props. The previously flagged "Thisis" typo on Organization.cs has been resolved.

Code Review Details

No new findings on this revision. The earlier suggestion (typo in the UseRiskInsights summary) has been addressed, the new using Bit.Core.AdminConsole.OrganizationFeatures.Policies; import in Policy.cs correctly resolves the IPolicyRequirementQuery cref reference, and the clarified docs on OrganizationInviteLink.Code accurately describe the field as a secret rather than a publicly shareable identifier.

eliykat and others added 3 commits May 5, 2026 14:37
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
@eliykat
eliykat requested review from a team and sven-bitwarden May 5, 2026 04:41
@sonarqubecloud

sonarqubecloud Bot commented May 5, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented May 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.04%. Comparing base (a523128) to head (e0a529d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7580      +/-   ##
==========================================
+ Coverage   59.64%   64.04%   +4.40%     
==========================================
  Files        2101     2101              
  Lines       92671    92671              
  Branches     8254     8254              
==========================================
+ Hits        55271    59350    +4079     
+ Misses      35447    31281    -4166     
- Partials     1953     2040      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eliykat
eliykat merged commit 5b06505 into main May 6, 2026
47 of 50 checks passed
@eliykat
eliykat deleted the ac/pm-36421/beeep-add-xmldoc-to-admin-console-entities branch May 6, 2026 22:14
@djsmith85 djsmith85 added the t:tech-debt Change Type - Tech debt label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants