Skip to content

[PM-35489] Move collections to AC ownership - update namespaces - #7532

Merged
eliykat merged 4 commits into
mainfrom
ac/pm-35489/server-move-collections-to-ac-ownership-namespaces
Apr 27, 2026
Merged

eliykat merged 4 commits into
mainfrom
ac/pm-35489/server-move-collections-to-ac-ownership-namespaces

Conversation

@eliykat

@eliykat eliykat commented Apr 22, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-35489

📔 Objective

Follow up from #7523 - update namespaces for moved files. Excludes some widely used files such as enums which would trigger all codeowners.

📸 Screenshots

@eliykat
eliykat requested review from a team as code owners April 22, 2026 22:51
@eliykat
eliykat enabled auto-merge (squash) April 22, 2026 22:51
harr1424
harr1424 previously approved these changes Apr 22, 2026

@harr1424 harr1424 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to files under Tools Team ownership look good ✅

@github-actions

github-actions Bot commented Apr 22, 2026 •

Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details – 7af77530-d02d-4dfe-9d8c-2a4c55d06215

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud

Copy link
Copy Markdown

typeof(OrganizationDomainController),
typeof(OrganizationsController),
typeof(OrganizationUsersController),
typeof(CollectionsController),

@eliykat eliykat Apr 22, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the controller to our namespace automatically made it covered by this test - as intended. However, it hasn't been migrated yet so it needs to go on the allowlist for now to avoid test failures.

@eliykat
eliykat requested a review from harr1424 April 22, 2026 23:44
@codecov

codecov Bot commented Apr 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.14%. Comparing base (2820ecc) to head (e65ab70).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7532   +/-   ##
=======================================
  Coverage   59.14%   59.14%           
=======================================
  Files        2077     2077           
  Lines       91859    91859           
  Branches     8177     8177           
=======================================
+ Hits        54326    54327    +1     
+ Misses      35601    35600    -1     
  Partials     1932     1932           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eliykat
eliykat merged commit a18b600 into main Apr 27, 2026
55 checks passed
@eliykat
eliykat deleted the ac/pm-35489/server-move-collections-to-ac-ownership-namespaces branch April 27, 2026 21:57
jaasen-livefront pushed a commit that referenced this pull request Apr 29, 2026
* Update namespaces: Api

* Update namespaces: core commands
@djsmith85 djsmith85 added the t:tech-debt Change Type - Tech debt label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants