Skip to content

Update matching for autotype desktop apps - #24844

Draft
coltonhurst wants to merge 1 commit into
dn/pm-47204from
dn/desktop-never-match-change
Draft

coltonhurst wants to merge 1 commit into
dn/pm-47204from
dn/desktop-never-match-change

Conversation

@coltonhurst

@coltonhurst coltonhurst commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

🎟️ Tracking

📔 Objective

Autotype desktop app pairings are saved as login URIs (desktopapp://autotype?…) with the Never match strategy. That keeps them from matching websites and from blocking HTTP authentication.

However, a pairing can still be stored without the never matching strategy, which could break the http auth setting feature. One way this is possible is if a user manually types desktopapp://{some text here} and then hits save. This login URI would then be treated as a desktop app pairing (though it would be an invalid one). (Even if we block this in the UI, it could come in through other means, such as the CLI, etc.)

Therefore, we need a way to ensure desktop pairings without the "Never" authentication matching strategy don't break the app. This PR therefore adds the following changes:

  • URI matching: LoginUriView.matchesUri never matches a URI that starts with desktopapp://, whatever its match strategy. The check ignores case and surrounding whitespace. Every pairing has the host autotype, so with a Host default, a pairing stored without Never would otherwise match http(s)://autotype/. All URI matching goes through this method: autofill, the inline menu, the notification bar, HTTP authentication, passkeys and list views.
  • Edit form: with the Autotype GA flag on, saved desktop apps now load in the form with Never, the strategy they're saved with. Before, the form held the stored strategy and only applied Never when saving. A pairing stored with no strategy therefore disabled the HTTP authentication setting, and turned it off when the form opened.
    • If the flag is read after the form opens, the desktop app rows are updated then.
    • A desktopapp:// value typed into a website row keeps the strategy the user picked until it's saved. It's still saved with Never, as before.
    • No HTTP authentication code changes.

Not changed: HTTP authentication still requires every URI to have an explicit match strategy. A login with a desktop app that has no strategy can't use HTTP authentication until it's saved with the GA flag on. If the flag is read after the form opens, the setting becomes available again, but if it was turned off, it stays off.

With the Autotype GA flag off, the edit form works as before. The matching change applies everywhere, but only to desktopapp:// URIs. The one other behavior change: bw list items --url "desktopapp://…" no longer returns items with that pairing. Nothing in the clients matches against a desktopapp:// URL.

📸 Screenshots

@coltonhurst coltonhurst self-assigned this Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant